Skip to content

fix css handling during ssr#1953

Closed
brenelz wants to merge 1 commit into
solidjs:devinxifrom
brenelz:fix-ssr-style-handling
Closed

fix css handling during ssr#1953
brenelz wants to merge 1 commit into
solidjs:devinxifrom
brenelz:fix-ssr-style-handling

Conversation

@brenelz
Copy link
Copy Markdown
Contributor

@brenelz brenelz commented Aug 24, 2025

Before this change the initial page styles wouldn't load with ssr in the prod build for the basic example.

You can see this with the count button on initial load.

Before:
image

After
image

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 24, 2025

⚠️ No Changeset found

Latest commit: 41fdd96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brenelz brenelz changed the title fix ssr style css handling fix css handling during ssr Aug 24, 2025
@Brendonovich
Copy link
Copy Markdown
Collaborator

In the process of redoing some manifest handling I actually ended up implementing this myself 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants